-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Website #2247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of comments, but looks good otherwise!
README.md
Outdated
See [CONTRIBUTING.md](https://github.com/rust-lang/rustlings/blob/main/CONTRIBUTING.md) 🔗 | ||
|
||
Thanks to [all the wonderful contributors](https://github.com/rust-lang/rustlings/graphs/contributors) ✨ | ||
# ➡️ [rustlings.rust-lang.org](https://rustlings.rust-lang.org) ⬅️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would at least keep a normal header, and a short description blurb, and maybe the one-liner installer. I feel like removing everything kind of messes with people who arrive here through direct link to GitHub (which is most links to Rustlings)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I added more context before the link :)
website/justfile
Outdated
zola serve --open | ||
|
||
tailwind: | ||
fnm exec --using latest npx @tailwindcss/cli -w -i input.css -o static/main.css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could this be changed to respect a .node-version
or the engines
field of package.json
, or something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just not sure if the recommended workflow should be having to use fnm
, I feel like using normal npx
and then guaranteeing a consistent version via some other means is better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fnm
is just what I personally use. I removed it. It uses npx
directly now.
TODO: