Skip to content

Website #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
May 23, 2025
Merged

Website #2247

merged 36 commits into from
May 23, 2025

Conversation

mo8it
Copy link
Contributor

@mo8it mo8it commented May 17, 2025

TODO:

  • New website CI
  • Final edits, especially to the custom exercises page
  • Update links, especially in changelog

@mo8it mo8it marked this pull request as ready for review May 17, 2025 20:08
@mo8it mo8it requested a review from manyinsects May 17, 2025 20:08
Copy link
Member

@manyinsects manyinsects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of comments, but looks good otherwise!

README.md Outdated
See [CONTRIBUTING.md](https://github.com/rust-lang/rustlings/blob/main/CONTRIBUTING.md) 🔗

Thanks to [all the wonderful contributors](https://github.com/rust-lang/rustlings/graphs/contributors) ✨
# ➡️ [rustlings.rust-lang.org](https://rustlings.rust-lang.org) ⬅️
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would at least keep a normal header, and a short description blurb, and maybe the one-liner installer. I feel like removing everything kind of messes with people who arrive here through direct link to GitHub (which is most links to Rustlings)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I added more context before the link :)

website/justfile Outdated
zola serve --open

tailwind:
fnm exec --using latest npx @tailwindcss/cli -w -i input.css -o static/main.css
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could this be changed to respect a .node-version or the engines field of package.json, or something like that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just not sure if the recommended workflow should be having to use fnm, I feel like using normal npx and then guaranteeing a consistent version via some other means is better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fnm is just what I personally use. I removed it. It uses npx directly now.

@mo8it mo8it merged commit 2267f99 into main May 23, 2025
1 of 6 checks passed
@mo8it mo8it deleted the website branch May 23, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants